[GitHub] mahout pull request #358: MAHOUT-2052 [WIP] Broken codeblock in a samsara tu...

[wwooww374]

GitHub user wwooww374 opened a pull request:

https://github.com/apache/mahout/pull/358

MAHOUT-2052 [WIP] Broken codeblock in a samsara tutorial html file.

### Purpose of PR:
As you can see below,
there is a broken codeblock and the tag ``<pre>`` is shown in a samsara tutorial html file.


This is because of ``<pre class="codehilite"></pre>`` and it should be changed to ``<div class="codehilite"><pre> ... </pre></div>``

### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should be made?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wwooww374/mahout codeblock

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #358

----
commit 46e79a49a7fe83f901f9df2d94fd0faf0d8e0f0f
Author: Jieun Kim <***@...>
Date: 2018-07-18T16:51:48Z

change the tag '<pre class=codehilite>' to '<div class=codehilite>'

----


---

[andrewmusselman]

Github user andrewmusselman commented on the issue:

https://github.com/apache/mahout/pull/358

Thanks for the edit! I am not seeing a repro case in two browsers (chrome and brave on ubuntu) but if you are able to check that this fixes this in your browser then I think it's good. I think `pre` is a block-level element so wrapping in a `div` wouldn't change much.

Which browser are you in?


---

[wwooww374]

Github user wwooww374 commented on the issue:

https://github.com/apache/mahout/pull/358

Thanks for your comment!

I tested my code in Chrome, Safari, and Brave by running ``jekyll serve`` and there was no change. As you said, I think this is not a problem with ``<pre>`` not wrapped in ``<div>``.

Instead, I separated ``<pre>`` tag section and text in new commit because all other codeblocks without this problem is separated from surrounding text. When I tested it in Chrome, Safari, and Brave, it fixed the problem.




---

[rawkintrevo]

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/358

@wwooww374 first of all, thanks for the contribution!

Second, this file was written in the old CMS website (pre jekyll) there are two additional options.
`<code> </code>` could replace `<pre></pre>` all together.

OR

In Markdown, code can be denoted by the back tick- e.g. `Shift+~` or ` it's hard to make it show up, bc Github also supports this kind of denoting.

If everything is working now thought, let me know- I'll test it on my system too.


---