[jira] [Updated] (MAHOUT-1907) Correctly implement VCL vector %*% matrix multiplication.

Discussion:

Andrew Palumbo (JIRA)

2017-01-17 00:11:26 UTC

Correctly implement VCL vector %*% matrix multiplication.
---------------------------------------------------------
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0
Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Andrew Palumbo (JIRA)

2017-01-17 00:11:26 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1907:
-----------------------------------
Summary: Correctly implement VCL vector %*% matrix multiplication. (was: Correctlu implement VCL vector %*% matrix multiplication.)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Andrew Palumbo (JIRA)

2017-01-17 00:11:26 UTC

Permalink

Andrew Palumbo created MAHOUT-1907:
--------------------------------------

Summary: Correctlu implement VCL vector %*% matrix multiplication.
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.2, 0.12.0
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0

Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Andrew Palumbo (JIRA)

2017-01-17 01:38:26 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824828#comment-15824828 ]

Andrew Palumbo commented on MAHOUT-1907:
----------------------------------------

blocker though after much discussion w KR, found simple solution.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Andrew Palumbo (JIRA)

2017-02-26 09:31:45 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MAHOUT-1907 started by Andrew Palumbo.
----------------------------------------------

Correctly implement VCL vector %*% matrix multiplication.
---------------------------------------------------------
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0
Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-02-26 21:42:46 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo resolved MAHOUT-1907.
------------------------------------
Resolution: Fixed

Correctly implement VCL vector %*% matrix multiplication.
---------------------------------------------------------
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0
Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-02-26 21:46:45 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884927#comment-15884927 ]

Andrew Palumbo commented on MAHOUT-1907:
----------------------------------------

Seeing some small Numerical differences here when operations are on GPU vs OMP/CPU or JVM/CPU.
"fixed" by relaxing the epsilon to 1e-10 from 1e-16; though this may affect highly iterative algorithms.:

{code}
+ ViennaCL/cpu/OpenMP Sparse multiplication time: 1577 ms.
- VCL Dense Matrix %*% Dense vector *** FAILED ***
1.5059797815742444E-16 was not less than 1.0E-16 (ViennaCLSuiteVCL.scala:349)
{code}

Correctly implement VCL vector %*% matrix multiplication.
---------------------------------------------------------
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0
Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Hudson (JIRA)

2017-02-26 22:17:45 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884932#comment-15884932 ]

Hudson commented on MAHOUT-1907:
--------------------------------

FAILURE: Integrated in Jenkins build Mahout-Quality #3425 (See [https://builds.apache.org/job/Mahout-Quality/3425/])
[MAHOUT-1903][MAHOUT-1907] VCL Vector memory copy fix. closes (apalumbo: rev 0f4b3d97cfc651a4bc052515b260648cd0093ac2)
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/VCLVector.scala
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/VectorBase.scala
* (edit) viennacl/src/test/scala/org/apache/mahout/viennacl/opencl/ViennaCLSuiteVCL.scala

Correctly implement VCL vector %*% matrix multiplication.
---------------------------------------------------------
Key: MAHOUT-1907
URL: https://issues.apache.org/jira/browse/MAHOUT-1907
Project: Mahout
Issue Type: Task
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.0
Vector/Matrix Multiplication is currently commented out in the VCL PR. after much discussion have found the Bug, will implement it after VCL is pushed.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)