Discussion:
[jira] [Created] (MAHOUT-1864) Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
giriraj sharma (JIRA)
2016-05-27 07:45:13 UTC
Permalink
giriraj sharma created MAHOUT-1864:
--------------------------------------

Summary: Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Priority: Minor
Fix For: 0.13.0


Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.

[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.

{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
giriraj sharma (JIRA)
2016-05-27 07:47:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303717#comment-15303717 ]

giriraj sharma commented on MAHOUT-1864:
----------------------------------------

I will issue a PR for the same and submit a patch if the minor improvement in the script seems fine,
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-27 08:45:13 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303761#comment-15303761 ]

ASF GitHub Bot commented on MAHOUT-1864:
----------------------------------------

GitHub user girirajsharma opened a pull request:

https://github.com/apache/mahout/pull/236

MAHOUT-1864: Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true

Twenty Newsgroups Classification Example fails in case running with `MAHOUT_LOCAL=true` or else when `HADOOP_HOME` env variable is not set.

[Newsgroups](https://mahout.apache.org/users/classification/twenty-newsgroups.html) lists instructions in order to run this classifier. When running in standalone mode(`MAHOUT_LOCAL=true`), i.e., running `$ ./examples/bin/classify-20newsgroups.sh`, the script runs `./examples/bin/set-dfs-commands.sh` internally to export hadoop related env variables.

`set-dfs-commands.sh` attempts to check for hadoop version despite running with `MAHOUT_LOCAL` set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script `./examples/bin/set-dfs-commands.sh` to export hadoop env varibales only in case `MAHOUT_LOCAL` is not set to true.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/girirajsharma/mahout master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #236

----
commit 59e6106c18a8e5493db34405b6d690834bdc45d3
Author: girirajsharma <***@gmail.com>
Date: 2016-05-27T07:48:27Z

MAHOUT-1864: Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true

----
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-27 16:56:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304337#comment-15304337 ]

ASF GitHub Bot commented on MAHOUT-1864:
----------------------------------------

Github user andrewpalumbo commented on the pull request:

https://github.com/apache/mahout/pull/236#issuecomment-222198320

Thank you for the patch, @girirajsharma. As you point out, `HADOOP_HOME` is a requisite in both local and distributed mode. So they are in fact working properly. IMO It would be best not to overcomplicate these scripts.

Mahout has actually phased out MapReduce over the past two years (see MAHOUT-1510) and now uses the Mahout "Samsara" framework: http://mahout.apache.org/users/sparkbindings/home.html. Mahout is not accepting new MapReduce features. Thank you.
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Suneel Marthi (JIRA)
2016-09-07 04:41:21 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469520#comment-15469520 ]

Suneel Marthi commented on MAHOUT-1864:
---------------------------------------

I would vote to resolve this jira as 'Won't Fix' . We have ceased support for this since 0.9 release.
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Andrew Palumbo (JIRA)
2016-09-07 12:09:21 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo resolved MAHOUT-1864.
------------------------------------
Resolution: Won't Fix
Assignee: Andrew Palumbo

Agreed
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Assignee: Andrew Palumbo
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-09-10 02:22:20 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478943#comment-15478943 ]

ASF GitHub Bot commented on MAHOUT-1864:
----------------------------------------

Github user andrewmusselman commented on the issue:

https://github.com/apache/mahout/pull/236

Let's close this; thanks Giri
Post by giriraj sharma (JIRA)
Twenty Newsgroups Classification Example fails in case running with MAHOUT_LOCAL=true
--------------------------------------------------------------------------------------
Key: MAHOUT-1864
URL: https://issues.apache.org/jira/browse/MAHOUT-1864
Project: Mahout
Issue Type: Improvement
Components: Examples
Affects Versions: 0.12.0
Reporter: giriraj sharma
Assignee: Andrew Palumbo
Priority: Minor
Labels: easyfix, easytest, newbie
Fix For: 0.13.0
Twenty Newsgroups Classification Example fails in case running with {{MAHOUT_LOCAL=true}} or else when {{HADOOP_HOME}} env variable is not set.
[Newsgroups|https://mahout.apache.org/users/classification/twenty-newsgroups.html] lists instructions in order to run this classifier. When running in standalone mode({{MAHOUT_LOCAL=true}}), i.e., running {{$ ./examples/bin/classify-20newsgroups.sh}}, the script runs {{./examples/bin/set-dfs-commands.sh}} internally to export hadoop related env variables.
{{set-dfs-commands.sh}} attempts to check for hadoop version despite running with {{MAHOUT_LOCAL}} set as true. IMHO, the script works fine considering the prerequisites, but, it will as well make sense if we can update the script {{./examples/bin/set-dfs-commands.sh}} to export hadoop env varibales only in case {{MAHOUT_LOCAL}} is not set to true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Loading...