[jira] [Created] (MAHOUT-1882) SequentialAccessSparseVector inerateNonZeros is incorrect.

[Andrew Palumbo (JIRA)]

Andrew Palumbo created MAHOUT-1882:
--------------------------------------

Summary: SequentialAccessSparseVector inerateNonZeros is incorrect.
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Fix For: 0.13.0


In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.

{code}
@Override
public Iterator<Element> iterateNonZero() {

// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Suneel Marthi (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576800#comment-15576800 ]

Suneel Marthi commented on MAHOUT-1882:
---------------------------------------

Is there a reproducible test case ?

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Sprint: Jan/Feb-2017

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Suneel Marthi (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suneel Marthi reassigned MAHOUT-1882:
-------------------------------------

Assignee: Suneel Marthi

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Priority: Critical (was: Major)

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Suneel Marthi (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suneel Marthi updated MAHOUT-1882:
----------------------------------
Comment: was deleted

(was: Is there a reproducible test case ? )

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Pat Ferrel (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812561#comment-15812561 ]

Pat Ferrel commented on MAHOUT-1882:
------------------------------------

Can't see that I use this, at least not obviously unless it is hidden in another call. Can you try removing the method and see who complains?

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Dmitriy Lyubimov (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812862#comment-15812862 ]

Dmitriy Lyubimov commented on MAHOUT-1882:
------------------------------------------

the fix is as easy as filtering 0s from non-default iterator (which i think is done right for RASV) and i think it is important since it may induce spurious non-deterministic behavior (e.g., switching results between 0 and NaN on seemingly the same input of `x ::= { 1 / _ }` )

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Sprint: Jan/Feb-2016 (was: Jan/Feb-2017)

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Sprint: Jan/Feb-2017 (was: Jan/Feb-2016)

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Priority: Critical
Fix For: 0.13.0
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Fix Version/s: (was: 0.13.0)
0.13.1

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Priority: Critical
Fix For: 0.13.1
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Andrew Palumbo (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1882:
-----------------------------------
Sprint: (was: Jan/Feb-2017)

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Priority: Critical
Fix For: 0.13.1
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886701#comment-15886701 ]

ASF GitHub Bot commented on MAHOUT-1882:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/290#discussion_r103334511

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/GPUMMul.scala ---
@@ -242,10 +242,11 @@ object GPUMMul extends MMBinaryFunc {
N.B. This method is horribly inefficent. However there is a difference between
getNumNonDefaultElements() and getNumNonZeroElements() which we do not always
have access to. We created MAHOUT-1882 for this.
- val hasElementsA = a.zSum() > 0.0
- val hasElementsB = b.zSum() > 0.0
*/

+ val hasElementsA = a.zSum() > 0.0
+ val hasElementsB = b.zSum() > 0.0
+
// A has a sparse matrix structure of unknown size. We do not want to
--- End diff --

No problems with it thanks @andrewmusselman.
There should be more println("gpurwrw"), etc, in this class could you use the logger for that please?

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Priority: Critical
Fix For: 0.13.1
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886706#comment-15886706 ]

ASF GitHub Bot commented on MAHOUT-1882:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/290#discussion_r103334831

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/GPUMMul.scala ---
@@ -242,10 +242,11 @@ object GPUMMul extends MMBinaryFunc {
N.B. This method is horribly inefficent. However there is a difference between
getNumNonDefaultElements() and getNumNonZeroElements() which we do not always
have access to. We created MAHOUT-1882 for this.
- val hasElementsA = a.zSum() > 0.0
- val hasElementsB = b.zSum() > 0.0
*/

+ val hasElementsA = a.zSum() > 0.0
+ val hasElementsB = b.zSum() > 0.0
+
// A has a sparse matrix structure of unknown size. We do not want to
--- End diff --

sorry was looking only at one commit.. i see that you already did.

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Priority: Critical
Fix For: 0.13.1
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Trevor Grant (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1882:
---------------------------------
Fix Version/s: (was: 0.13.1)
0.13.2

Post by Andrew Palumbo (JIRA)
SequentialAccessSparseVector inerateNonZeros is incorrect.
----------------------------------------------------------
Key: MAHOUT-1882
URL: https://issues.apache.org/jira/browse/MAHOUT-1882
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.2
Reporter: Andrew Palumbo
Priority: Critical
Fix For: 0.13.2
In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero elements {{NonDefaultIterator}} can, under certain circumstances give an incorrect iterator of size different from the actual non-zeroCounts.
{code}
@Override
public Iterator<Element> iterateNonZero() {
// TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero contract.
return new NonDefaultIterator();
}
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)