Discussion:
[jira] [Created] (MAHOUT-1926) Linear Regression Model can generate p-values outside of [0,1]
Trevor Grant (JIRA)
2017-02-01 03:38:51 UTC
Permalink
Trevor Grant created MAHOUT-1926:
------------------------------------

Summary: Linear Regression Model can generate p-values outside of [0,1]
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant


Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.

Need to recreate problem with toy data set, fix, and add test.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Trevor Grant (JIRA)
2017-02-01 21:47:51 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1926:
---------------------------------
Sprint: Jan/Feb-2017
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Trevor Grant (JIRA)
2017-02-01 22:55:51 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1926:
---------------------------------
Fix Version/s: 0.13.0
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Trevor Grant (JIRA)
2017-02-27 01:51:45 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MAHOUT-1926 started by Trevor Grant.
--------------------------------------------
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Trevor Grant (JIRA)
2017-02-27 01:51:45 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant reassigned MAHOUT-1926:
------------------------------------

Assignee: Trevor Grant
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
ASF GitHub Bot (JIRA)
2017-02-27 03:28:46 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885079#comment-15885079 ]

ASF GitHub Bot commented on MAHOUT-1926:
----------------------------------------

GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/288

MAHOUT-1926 Fix p-value calculation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1926

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #288

----
commit 197a536b97fc4cb03ce9359dca8178c488786bb8
Author: rawkintrevo <***@gmail.com>
Date: 2017-02-27T03:27:10Z

MAHOUT-1926 Fix p-value calculation

----
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
ASF GitHub Bot (JIRA)
2017-02-27 04:57:45 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885136#comment-15885136 ]

ASF GitHub Bot commented on MAHOUT-1926:
----------------------------------------

Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/288
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Trevor Grant (JIRA)
2017-02-27 05:03:45 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant resolved MAHOUT-1926.
----------------------------------
Resolution: Fixed
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
Hudson (JIRA)
2017-02-27 05:26:46 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885158#comment-15885158 ]

Hudson commented on MAHOUT-1926:
--------------------------------

FAILURE: Integrated in Jenkins build Mahout-Quality #3430 (See [https://builds.apache.org/job/Mahout-Quality/3430/])
MAHOUT-1926 Fix p value calc closes apache/mahout#288 (rawkintrevo: rev 4e0106ae5edafbef7b1411d66bc5f9e9bf44045a)
* (edit) math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/LinearRegressorModel.scala
Post by Trevor Grant (JIRA)
Linear Regression Model can generate p-values outside of [0,1]
--------------------------------------------------------------
Key: MAHOUT-1926
URL: https://issues.apache.org/jira/browse/MAHOUT-1926
Project: Mahout
Issue Type: Bug
Components: Algorithms
Affects Versions: 0.13.0
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.0
Anecdotally, the p-values reported by the ordinary least squares model (utilizing the functionality in the parent, LinearRegressionFitter) have been reported outside the range of [0,1] which is nonsensical.
Need to recreate problem with toy data set, fix, and add test.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Loading...