[jira] [Created] (MAHOUT-1971) Aggregate Transpose Bug

[Trevor Grant (JIRA)]

Trevor Grant created MAHOUT-1971:
------------------------------------

Summary: Aggregate Transpose Bug
Key: MAHOUT-1971
URL: https://issues.apache.org/jira/browse/MAHOUT-1971
Project: Mahout
Issue Type: Bug
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.1


In the At operation of Flink and spark there is a line that looks like:

case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)

that ought to be

case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)

Since it isnt'- the 'aggregate transpose' does not operate as expected.

This needs to be updated in the Spark and Flink bindings (same one char fix).

Test coverage should be updated to catch this.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980072#comment-15980072 ]

ASF GitHub Bot commented on MAHOUT-1971:
----------------------------------------

GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/307

MAHOUT-1971 Aggregate Transpose Bug

Fixes in Spark and Flink bindings- adds test coverage to both.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1971

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #307

----
commit 371dfc26a411768b2eae5111edb269b9c9301d2e
Author: rawkintrevo <***@gmail.com>
Date: 2017-04-22T18:38:05Z

MAHOUT-1971 Aggregate Transpose Bug

----

Post by Trevor Grant (JIRA)
Aggregate Transpose Bug
-----------------------
Key: MAHOUT-1971
URL: https://issues.apache.org/jira/browse/MAHOUT-1971
Project: Mahout
Issue Type: Bug
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.1
case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
that ought to be
case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
Since it isnt'- the 'aggregate transpose' does not operate as expected.
This needs to be updated in the Spark and Flink bindings (same one char fix).
Test coverage should be updated to catch this.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980084#comment-15980084 ]

ASF GitHub Bot commented on MAHOUT-1971:
----------------------------------------

Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/307

Post by Trevor Grant (JIRA)
Aggregate Transpose Bug
-----------------------
Key: MAHOUT-1971
URL: https://issues.apache.org/jira/browse/MAHOUT-1971
Project: Mahout
Issue Type: Bug
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.1
case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
that ought to be
case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
Since it isnt'- the 'aggregate transpose' does not operate as expected.
This needs to be updated in the Spark and Flink bindings (same one char fix).
Test coverage should be updated to catch this.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Trevor Grant (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant resolved MAHOUT-1971.
----------------------------------
Resolution: Fixed

Post by Trevor Grant (JIRA)
Aggregate Transpose Bug
-----------------------
Key: MAHOUT-1971
URL: https://issues.apache.org/jira/browse/MAHOUT-1971
Project: Mahout
Issue Type: Bug
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.1
case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
that ought to be
case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
Since it isnt'- the 'aggregate transpose' does not operate as expected.
This needs to be updated in the Spark and Flink bindings (same one char fix).
Test coverage should be updated to catch this.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Hudson (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980095#comment-15980095 ]

Hudson commented on MAHOUT-1971:
--------------------------------

SUCCESS: Integrated in Jenkins build Mahout-Quality #3479 (See [https://builds.apache.org/job/Mahout-Quality/3479/])
MAHOUT-1971 Aggregate Transpose Bug closes apache/mahout#307 (rawkintrevo: rev 08e02602e947ff945b9bd73ab5f0b45863df3e53)
* (edit) spark/src/main/scala/org/apache/mahout/sparkbindings/blas/At.scala
* (edit) flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAt.scala
* (edit) spark/src/test/scala/org/apache/mahout/sparkbindings/drm/DrmLikeSuite.scala
* (edit) flink/src/test/scala/org/apache/mahout/flinkbindings/DrmLikeOpsSuite.scala

Post by Trevor Grant (JIRA)
Aggregate Transpose Bug
-----------------------
Key: MAHOUT-1971
URL: https://issues.apache.org/jira/browse/MAHOUT-1971
Project: Mahout
Issue Type: Bug
Reporter: Trevor Grant
Assignee: Trevor Grant
Fix For: 0.13.1
case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
that ought to be
case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
Since it isnt'- the 'aggregate transpose' does not operate as expected.
This needs to be updated in the Spark and Flink bindings (same one char fix).
Test coverage should be updated to catch this.

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)