Discussion:
[jira] [Created] (MAHOUT-1841) Matrices.symmetricUniformView(...) returning values in the wrong range.
Andrew Palumbo (JIRA)
2016-04-30 00:35:12 UTC
Permalink
Andrew Palumbo created MAHOUT-1841:
--------------------------------------

Summary: Matrices.symmetricUniformView(...) returning values in the wrong range.
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Fix For: 0.12.1


Per javadocs, {{Matrices.symmetricUniformView(...)}} is meant to return values in on the range of [-1,1):

{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
* @param seed generator seed
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}

Ranges being returned now are on (-.5,.5).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Suneel Marthi (JIRA)
2016-04-30 00:48:13 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suneel Marthi reassigned MAHOUT-1841:
-------------------------------------

Assignee: Suneel Marthi
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Suneel Marthi (JIRA)
2016-05-01 05:16:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suneel Marthi resolved MAHOUT-1841.
-----------------------------------
Resolution: Fixed
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Hudson (JIRA)
2016-05-01 06:26:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265634#comment-15265634 ]

Hudson commented on MAHOUT-1841:
--------------------------------

FAILURE: Integrated in Mahout-Quality #3348 (See [https://builds.apache.org/job/Mahout-Quality/3348/])
MAHOUT-1841: Matrices.symmetricUniformView(...) returning values in the (smarthi: rev 1127661fd96cac6d7584ba50b717bc67bda4aa43)
* math/src/main/java/org/apache/mahout/math/Matrices.java
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-01 17:21:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265836#comment-15265836 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user andrewpalumbo closed the pull request at:

https://github.com/apache/mahout/pull/231
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-01 17:21:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265837#comment-15265837 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

GitHub user andrewpalumbo reopened a pull request:

https://github.com/apache/mahout/pull/231

MAHOUT-1841 change UNIFORM_DIVISOR to 2^63 from 2^64

Matrices.SymmetricUniformView is returning numbers on the range of (-.5,.5). Documentation calls for [1,1).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewpalumbo/mahout uniform

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #231

----
commit 1c9bb55676e0247fcbd62313dbbb311db4f922fd
Author: Andrew Palumbo <***@apache.org>
Date: 2016-05-01T02:19:24Z

change UNIFORM_DIVISOR to 2^63 from 2^64

----
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-01 17:26:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265841#comment-15265841 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user andrewpalumbo commented on the pull request:

https://github.com/apache/mahout/pull/231#issuecomment-216057236

It failed in travis also... hadn't noticed that:
```
- dals *** FAILED ***
9043.008205882092 was not less than 0.15 (DistributedDecompositionsSuiteBase.scala:215)
```
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-01 19:21:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265894#comment-15265894 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user andrewpalumbo commented on the pull request:

https://github.com/apache/mahout/pull/231#issuecomment-216065594

@dlyubimov do you have any thoughts on why this might fail for `dals` only and only on certain java distributions?
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-05-01 21:49:12 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265962#comment-15265962 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user andrewpalumbo commented on the pull request:

https://github.com/apache/mahout/pull/231#issuecomment-216075007

reverted in master by 0d6c4e02409a6f8da776d00dc661fd178a7630b2
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Hudson (JIRA)
2016-05-01 22:35:13 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265983#comment-15265983 ]

Hudson commented on MAHOUT-1841:
--------------------------------

SUCCESS: Integrated in Mahout-Quality #3349 (See [https://builds.apache.org/job/Mahout-Quality/3349/])
Revert "MAHOUT-1841: Matrices.symmetricUniformView(...) returning values (apalumbo: rev 0d6c4e02409a6f8da776d00dc661fd178a7630b2)
* math/src/main/java/org/apache/mahout/math/Matrices.java
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Andrew Palumbo (JIRA)
2016-05-03 18:27:13 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269296#comment-15269296 ]

Andrew Palumbo commented on MAHOUT-1841:
----------------------------------------

Current status is:

{{code}}
dals *** FAILED ***
9043.008205882092 was not less than 0.15 (DistributedDecompositionsSuiteBase.scala:215)
{{code}}

on certain jdks for certain platforms. see PR#231 for more detail.
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-09-10 02:23:20 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478946#comment-15478946 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user andrewmusselman commented on the issue:

https://github.com/apache/mahout/pull/231

Should this stay open or be closed?
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-09-10 02:30:20 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478959#comment-15478959 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user smarthi commented on the issue:

https://github.com/apache/mahout/pull/231

Close it, too risky a fix and it's not easy to reproduce

Sent from my iPhone
Post by ASF GitHub Bot (JIRA)
Should this stay open or be closed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2016-09-10 03:20:20 UTC
Permalink
[ https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479033#comment-15479033 ]

ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------

Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/231
Post by Andrew Palumbo (JIRA)
Matrices.symmetricUniformView(...) returning values in the wrong range.
-----------------------------------------------------------------------
Key: MAHOUT-1841
URL: https://issues.apache.org/jira/browse/MAHOUT-1841
Project: Mahout
Issue Type: Bug
Components: Math
Affects Versions: 0.12.0
Reporter: Andrew Palumbo
Assignee: Suneel Marthi
Fix For: 0.12.1
{code}
/**
* Matrix view based on uniform [-1,1) distribution.
*
*/
public static final Matrix symmetricUniformView(final int rows,
final int columns,
int seed) {
return functionalMatrixView(rows, columns, uniformSymmetricGenerator(seed), true);
}
{code}
Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Loading...