[jira] [Created] (MAHOUT-1795) Release Scala 2.11 bindings

[Mike Kaplinskiy (JIRA)]

Mike Kaplinskiy created MAHOUT-1795:
---------------------------------------

Summary: Release Scala 2.11 bindings
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy


It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).

It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Mike Kaplinskiy (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Kaplinskiy updated MAHOUT-1795:
------------------------------------
Attachment: patch.diff

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Suneel Marthi (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026353#comment-15026353 ]

Suneel Marthi commented on MAHOUT-1795:
---------------------------------------

Could u create a git PR? its easier to review and merge PRs.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Mike Kaplinskiy (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026358#comment-15026358 ]

Mike Kaplinskiy commented on MAHOUT-1795:
-----------------------------------------

I doubt you'd want to merge it - I removed the spark shell from the build in that patch.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026361#comment-15026361 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

GitHub user mikekap opened a pull request:

https://github.com/apache/mahout/pull/179

[DO NOT MERGE] Terrible hack to compile math & spark bindings under scala 2.11

Proof of concept for https://issues.apache.org/jira/browse/MAHOUT-1795

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mikekap/mahout 2.11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #179

----
commit 1d463c49cef8eb2591ecd3e47b04041b68086a1a
Author: Mike Kaplinskiy <***@twitter.com>
Date: 2015-11-25T07:33:18Z

Terrible hack to compile math & spark bindings under scala 2.11

----

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Mike Kaplinskiy (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026358#comment-15026358 ]

Mike Kaplinskiy edited comment on MAHOUT-1795 at 11/25/15 7:34 AM:
-------------------------------------------------------------------

I doubt you'd want to merge it - I removed the spark shell from the build in that patch. See https://github.com/apache/mahout/pull/179


was (Author: mkaplinskiy):
I doubt you'd want to merge it - I removed the spark shell from the build in that patch.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029483#comment-15029483 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user mikekap commented on the pull request:

https://github.com/apache/mahout/pull/179#issuecomment-160048937

Updated to not be a terrible hack, but formalizes excluding spark-shell from the 2.11 build. (If you look at the way spark itself tackles the 2.10/2.11 split - shell will need completely different code for 2.11.)

If this does get accepted, it would be nice to also set up CI for scala 2.11 (mvn -Dscala-2.11 ...) :)

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184004#comment-15184004 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user dlyubimov commented on the pull request:

https://github.com/apache/mahout/pull/179#issuecomment-193503313

Can somebody else to look this over -- we may want to include this if it truly enables 2.11 build

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184005#comment-15184005 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user dlyubimov commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r55292335

--- Diff: spark/src/main/scala/org/apache/mahout/sparkbindings/blas/ABt.scala ---
@@ -29,8 +29,6 @@ import org.apache.spark.SparkContext._
import org.apache.mahout.math.drm.logical.OpABt
import org.apache.mahout.logging._

-import scala.tools.nsc.io.Pickler.TildeDecorator
-
/** Contains RDD plans for ABt operator */
--- End diff --

is this really there? oh. it is. good catch +1.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184012#comment-15184012 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user dlyubimov commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r55292523

--- Diff: pom.xml ---
@@ -804,13 +798,15 @@
<module>distribution</module>
<module>math-scala</module>
<module>spark</module>
- <module>spark-shell</module>
--- End diff --

why are we dropping spark-shell from the build?

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184015#comment-15184015 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user dlyubimov commented on the pull request:

https://github.com/apache/mahout/pull/179#issuecomment-193505384

+1, preliminarily. still don't understand why this seems to exclude spark-shell from the build.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184200#comment-15184200 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user mikekap commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r55305279

--- Diff: pom.xml ---
@@ -804,13 +798,15 @@
<module>distribution</module>
<module>math-scala</module>
<module>spark</module>
- <module>spark-shell</module>
--- End diff --

Converting spark-shell is a nontrivial task that I don't have time to tackle. Spark itself has distinct shell code for 2.11 & 2.10. This change just formalizes excluding spark-shell from the 2.11 build; in a perfect universe the majority of this change wouldn't be needed.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Suneel Marthi (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suneel Marthi updated MAHOUT-1795:
----------------------------------
Fix Version/s: 1.0.0

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[Saikat Kanjilal (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218625#comment-15218625 ]

Saikat Kanjilal commented on MAHOUT-1795:
-----------------------------------------

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478969#comment-15478969 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user andrewmusselman commented on the issue:

https://github.com/apache/mahout/pull/179

@mikekap can you explain why converting spark-shell for the 2.11 build is non-trivial, maybe give some more context?

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482837#comment-15482837 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user mikekap commented on the issue:

https://github.com/apache/mahout/pull/179

I haven't looked too far in depth, but as I mentioned above, spark itself has completely separate (probably not API-compatible) source trees for spark [2.11](https://github.com/apache/spark/tree/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl) and [2.10](https://github.com/apache/spark/tree/master/repl/scala-2.10/src/main/scala/org/apache/spark/repl). The code doesn't seem even remotely similar to me, and I likely don't have the expertise to convert that mahout shell code to work with 2.11.

Let me know if you'd like be to rebase this.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849923#comment-15849923 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179

Hey Mike-

Sorry to let this thread go dead- can you rebase this? Working on Spark 2.x and this becomes much more relevant. Also re: shell- I'm proposing dropping in favor of this approach.
https://github.com/apache/mahout/pull/271

Thanks for your contribution!

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854541#comment-15854541 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user mikekap commented on the issue:

https://github.com/apache/mahout/pull/179

I'm happy to rebase this, but if you don't mind I'll wait until #271 is merged. It would be trivial to enable scala 2.11 if the shell is gone :)

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882696#comment-15882696 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179

@mikekap #271 is merged. Please re-base.

Would _love_ to get this in for 0.13.0 if possible.

Thank you again for the contribution!

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937738#comment-15937738 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974031#comment-15974031 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user andrewmusselman commented on the issue:

https://github.com/apache/mahout/pull/179

Now that 0.13.0 is out, is this still something we'd want to put in 0.13.1?

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018679#comment-16018679 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179

hey @mikekap sorry I missed this- we changed the travis yml. Can you rebase off of that. This is failing on the viennaCL stuff, this is a known problem (scala 2.11 not working with viennaCL bindings). The new travis.yml tests for spark 1.6/scala 2.10, spark 2.0/scala 2.11, spark 2.1/scala 2.11.

But the scala 2.11's aren't tested with viennaCL. (only scala 2.10)

this should fix your build issue, and if you woundn't mind update the travis yml to utilize your profiles.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053540#comment-16053540 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r122633209

--- Diff: spark/src/main/assembly/dependency-reduced.xml ---
@@ -38,14 +38,14 @@
<includes>
<!-- guava only included to get Preconditions in mahout-math and mahout-hdfs -->
<include>com.google.guava:guava</include>
- <include>com.github.scopt</include>
+ <include>com.github.scopt_${scala.compat.version}</include>
--- End diff --

@pferrel @andrewpalumbo is this the thing ^^

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 1.0.0
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Trevor Grant (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1795:
---------------------------------
Fix Version/s: (was: 1.0.0)
0.13.2

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 0.13.2
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Trevor Grant (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1795:
---------------------------------
Fix Version/s: (was: 0.13.2)
0.13.1

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 0.13.1
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061712#comment-16061712 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r123866644

--- Diff: pom.xml ---
@@ -917,6 +914,26 @@
</properties>
</profile>
<profile>
+ <id>scala-2.10</id>
+ <activation>
+ <property><name>!scala-2.11</name></property>
+ </activation>
+ <properties>
+ <scala.compat.version>2.10</scala.compat.version>
+ <scala.version>2.10.4</scala.version>
+ </properties>
+ </profile>
+ <profile>
+ <id>scala-2.11</id>
+ <activation>
+ <property><name>scala-2.11</name></property>
+ </activation>
+ <properties>
+ <scala.compat.version>2.11</scala.compat.version>
+ <scala.version>2.11.8</scala.version>
--- End diff --

We need to cap at 2.11.2 to maintain breeze compatibility. see https://github.com/apache/mahout/pull/326/files#diff-5d8d832c3c4016dd77a9c3d92a2c5b69

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 0.13.1
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063855#comment-16063855 ]

ASF GitHub Bot commented on MAHOUT-1795:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179

going to merge this and fix outstanding issues with other PRs.

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 0.13.1
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Trevor Grant (JIRA)]

[ https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant resolved MAHOUT-1795.
----------------------------------
Resolution: Fixed

Post by Mike Kaplinskiy (JIRA)
Release Scala 2.11 bindings
---------------------------
Key: MAHOUT-1795
URL: https://issues.apache.org/jira/browse/MAHOUT-1795
Project: Mahout
Issue Type: Improvement
Reporter: Mike Kaplinskiy
Fix For: 0.13.1
Attachments: patch.diff
It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. (I'm not sure of other users, but mahout-shell isn't nearly at the top of my list here).
It looks simple enough for those two - the attached patch is a proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not sure what the proper way to do this is, but it doesn't look too daunting. (Famous last words?)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)