[jira] [Updated] (MAHOUT-1988) scala 2.10 is hardcoded somewhere

Discussion:

Andrew Palumbo (JIRA)

2017-05-26 02:20:04 UTC

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Palumbo updated MAHOUT-1988:
-----------------------------------
Summary: scala 2.10 is hardcoded somewhere (was: scala 2.10 is hardcoded )

scala 2.10 is hardcoded somewhere
----------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-05-26 02:20:04 UTC

Permalink

Post by Andrew Palumbo (JIRA)
scala 2.10 is hardcoded
-------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-05-25 00:33:04 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023949#comment-16023949 ]

Andrew Palumbo commented on MAHOUT-1988:
----------------------------------------

{code}
<include>org.apache.mahout:mahout-native-viennacl_2.10</include> <include>org.apache.mahout:mahout-native-viennacl-omp_2.10</include>
{code}

Not the cause but needs a solution none the less.. badhack: just include 2.10 and 2.11 here.

Post by Andrew Palumbo (JIRA)
ViennaCL jars are Hard coded to scala 2.10
---------------------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-05-25 01:09:04 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023978#comment-16023978 ]

Andrew Palumbo commented on MAHOUT-1988:
----------------------------------------

scopt stuck at 2.10:
{code}
***@micheal:~/sandbox/mahout_cuda/viennacl$ mvn dependency:tree -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-native-viennacl_2.11:jar:0.13.1-SNAPSHOT
[WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-native-viennacl_${scala.compat.version}:[unknown-version], /home/andy/sandbox/mahout_cuda/viennacl/pom.xml, line 30, column 15
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:exec-maven-plugin @ org.apache.mahout:mahout-native-viennacl_${scala.compat.version}:[unknown-version], /home/andy/sandbox/mahout_cuda/viennacl/pom.xml, line 180, column 15
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Mahout Native VienniaCL OpenCL Bindings 0.13.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.3:tree (default-cli) @ mahout-native-viennacl_2.11 ---
[INFO] org.apache.mahout:mahout-native-viennacl_2.11:jar:0.13.1-SNAPSHOT
[INFO] +- org.apache.mahout:mahout-math-scala_2.11:jar:0.13.1-SNAPSHOT:compile
[INFO] | +- org.apache.mahout:mahout-math:jar:0.13.1-SNAPSHOT:compile
[INFO] | | +- org.apache.commons:commons-math3:jar:3.2:compile
[INFO] | | +- com.google.guava:guava:jar:14.0.1:compile
[INFO] | | +- it.unimi.dsi:fastutil:jar:7.0.12:compile
[INFO] | | +- org.slf4j:slf4j-api:jar:1.7.22:compile
[INFO] | | \- com.tdunning:t-digest:jar:3.1:compile
[INFO] | +- com.esotericsoftware.kryo:kryo:jar:2.24.0:compile
[INFO] | | +- com.esotericsoftware.minlog:minlog:jar:1.2:compile
[INFO] | | \- org.objenesis:objenesis:jar:2.1:compile
[INFO] | +- com.github.scopt:scopt_2.10:jar:3.3.0:compile
[INFO] | | \- org.scala-lang:scala-library:jar:2.11.2:compile
[INFO] | \- org.scala-lang:scala-reflect:jar:2.10.4:compile
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- org.scalatest:scalatest_2.11:jar:2.2.4:test
[INFO] | \- org.scala-lang.modules:scala-xml_2.11:jar:1.0.2:test
[INFO] \- org.bytedeco:javacpp:jar:1.2.4:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.798 s
[INFO] Finished at: 2017-05-24T18:06:30-07:00
[INFO] Final Memory: 19M/323M
[INFO] ------------------------------------------------------------------------
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-05-25 01:24:04 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023996#comment-16023996 ]

Andrew Palumbo commented on MAHOUT-1988:
----------------------------------------

[~pferrel] It looks like scopt is stuck at scala 2.10 as a transitive dep for ViennaCL.. When I check the dep tree from {{math-scala}} looks like we're pulling the right on scala version, but transitively we end up with {{com.github.scopt:scopt_2.10:jar:3.3.0}}.

This is blocking the scala 2.11 release- Any thoughts? I think its something inherently wrong with our poms..

{code}
***@micheal:~/sandbox/mahout_cuda/math-scala$ mvn dependency:tree -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Building Mahout Math Scala bindings 0.13.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ mahout-math-scala_2.11 ---
[INFO] org.apache.mahout:mahout-math-scala_2.11:jar:0.13.1-SNAPSHOT
[INFO] +- org.apache.mahout:mahout-math:jar:0.13.1-SNAPSHOT:compile
[INFO] | +- org.apache.commons:commons-math3:jar:3.2:compile
[INFO] | +- com.google.guava:guava:jar:14.0.1:compile
[INFO] | +- it.unimi.dsi:fastutil:jar:7.0.12:compile
[INFO] | +- org.slf4j:slf4j-api:jar:1.7.22:compile
[INFO] | \- com.tdunning:t-digest:jar:3.1:compile
[INFO] +- com.esotericsoftware.kryo:kryo:jar:2.24.0:compile
[INFO] | +- com.esotericsoftware.minlog:minlog:jar:1.2:compile
[INFO] | \- org.objenesis:objenesis:jar:2.1:compile
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- com.github.scopt:scopt_2.11:jar:3.3.0:compile
[INFO] | \- org.scala-lang:scala-library:jar:2.11.4:compile
[INFO] +- org.scalatest:scalatest_2.11:jar:2.2.4:test
[INFO] | \- org.scala-lang.modules:scala-xml_2.11:jar:1.0.2:test
[INFO] \- org.scala-lang:scala-reflect:jar:2.11.4:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.810 s
[INFO] Finished at: 2017-05-24T18:13:23-07:00
[INFO] Final Memory: 19M/323M
[INFO] ------------------------------------------------------------------------
{code}

transitive (spark module):
{code}
***@micheal:~/sandbox/mahout_cuda/spark$ mvn dependency:tree -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 | grep scopt
[INFO] | +- com.github.scopt:scopt_2.10:jar:3.3.0:compile
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Andrew Palumbo (JIRA)

2017-05-24 23:40:04 UTC

Permalink

Andrew Palumbo created MAHOUT-1988:
--------------------------------------

Summary: ViennaCL jars are Hard coded to scala 2.10
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1

After building mahout against scala 2.11:
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}

ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.

{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Pat Ferrel (JIRA)

2017-06-05 20:52:04 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037567#comment-16037567 ]

Pat Ferrel commented on MAHOUT-1988:
------------------------------------

Don't have time to look now but believe Scopt may hardcode 2.10. I know and use the 2.11 version and it is very little changed so putting one in the scala 2.10 profile and another in the 2.11 should be simple, no?

Post by Andrew Palumbo (JIRA)
scala 2.10 is hardcoded somewhere
----------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Trevor Grant (JIRA)

2017-06-19 07:38:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053558#comment-16053558 ]

Trevor Grant commented on MAHOUT-1988:
--------------------------------------

I think we have a bit of a herring on the scopt thing.

You'll notice right below that `org.scala-lang:scala-reflect:jar:2.10.4:compile` and I think scala-reflect is what is actually causing the errors (based on memory). Hopefully the same root cause though.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Trevor Grant (JIRA)

2017-06-19 08:41:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053628#comment-16053628 ]

Trevor Grant commented on MAHOUT-1988:
--------------------------------------

OK I manually added the troublesome dependencies to the viennacl pom and that got rid of the reflection warnings:

```
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-reflect</artifactId>
<version>${scala.version}</version>
</dependency>

<dependency>
<groupId>com.github.scopt</groupId>
<artifactId>scopt_${scala.compat.version}</artifactId>
<version>3.3.0</version>
</dependency>
```

Now I'm not sure those were the issue at all.

We have the following errors:

```
[ERROR] /home/rawkintrevo/gits/mahout/viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/CompressedMatrix.scala:33: error: in class CompressedMatrix, multiple overloaded alternatives of constructor CompressedMatrix define default arguments.
[ERROR] final class CompressedMatrix(defaultCtr: Boolean = true) extends Pointer {
[ERROR] ^
[ERROR] /home/rawkintrevo/gits/mahout/viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala:37: error: in class DenseColumnMatrix, multiple overloaded alternatives of constructor DenseColumnMatrix define default arguments.
[ERROR] final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {
[ERROR] ^
[ERROR] /home/rawkintrevo/gits/mahout/viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseRowMatrix.scala:32: error: in class DenseRowMatrix, multiple overloaded alternatives of constructor DenseRowMatrix define default arguments.
[ERROR] class DenseRowMatrix(initDefault: Boolean = true) extends MatrixBase {
[ERROR] ^
[ERROR] /home/rawkintrevo/gits/mahout/viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/VCLVector.scala:30: error: in class VCLVector, multiple overloaded alternatives of constructor VCLVector define default arguments.
[ERROR] final class VCLVector(defaultCtr: Boolean = true) extends VectorBase {
[ERROR] ^
```

I think this is an issue with Scala 2.11 being a little more strict on declarations:

https://www.chrisstucchio.com/blog/2014/multiple_overloaded_alternatives.html

[~Andrew_Palumbo] can you take a look?

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Trevor Grant (JIRA)

2017-06-21 22:00:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant reassigned MAHOUT-1988:
------------------------------------

Assignee: Trevor Grant

Post by Andrew Palumbo (JIRA)
scala 2.10 is hardcoded somewhere
----------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Trevor Grant
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-21 22:01:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058329#comment-16058329 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/326

MAHOUT-1988 Make Native Solvers Scala 2.11 Complient

### Purpose of PR:
Please give a short description of what this PR is for.

### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
- [x] Assigned JIRA to self
- [x] Successfully built and ran all unit tests, verified that all tests pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions?
no

Is this the beginning of a larger project for which a feature branch should be made?
no

Issue was- as error message stated, default arguments not allowed in multiple constructors- scala gets confuzzled.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #326

----
commit 76408bf1a76fb0e028859d898b6c231f0e29a9fb
Author: rawkintrevo <***@gmail.com>
Date: 2017-06-21T21:59:01Z

MAHOUT-1988 Make Native Solvers Scala 2.11 Complient

----

Post by Andrew Palumbo (JIRA)
scala 2.10 is hardcoded somewhere
----------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Trevor Grant
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-22 16:14:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059620#comment-16059620 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/326

fwiw- this doesn't actually fix the dependency issue. I think I'll make a new jira ticket for this, then down grade mahout-1988 to trivial

Post by Andrew Palumbo (JIRA)
scala 2.10 is hardcoded somewhere
----------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Trevor Grant
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Trevor Grant (JIRA)

2017-06-23 04:55:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant updated MAHOUT-1988:
---------------------------------
Summary: ViennaCL and OMP not building for Scala 2.11 (was: scala 2.10 is hardcoded somewhere)

ViennaCL and OMP not building for Scala 2.11
--------------------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Trevor Grant
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-23 20:55:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061486#comment-16061486 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/326

getting: ```*** RUN ABORTED ***
java.lang.NoSuchMethodError: scala.runtime.IntRef.create(I)Lscala/runtime/IntRef;
at org.apache.mahout.viennacl.opencl.package$.repackCSR(package.scala:227)
at org.apache.mahout.viennacl.opencl.package$.toVclCmpMatrixAlt(package.scala:120)
at org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$gpuRWCW(GPUMMul.scala:161)
at org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$jvmRWRW(GPUMMul.scala:208)
at org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78)
at org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78)
at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:127)
at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:33)
at org.apache.mahout.math.scalabindings.RLikeMatrixOps.$percent$times$percent(RLikeMatrixOps.scala:37)
at org.apache.mahout.opencl.viennacl.ViennaCLSuiteVCL$$anonfun$2.apply$mcV$sp(ViennaCLSuiteVCL.scala:92)``` when running `mvn test` in the viennacl package.

Post by Trevor Grant (JIRA)
ViennaCL and OMP not building for Scala 2.11
--------------------------------------------
Key: MAHOUT-1988
URL: https://issues.apache.org/jira/browse/MAHOUT-1988
Project: Mahout
Issue Type: Bug
Affects Versions: 0.13.0
Reporter: Andrew Palumbo
Assignee: Trevor Grant
Priority: Blocker
Fix For: 0.13.1
{code}
mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 -Phadoop2 -DskipTests
{code}
ViennaCL jars are built hard-coded to scala 2.10. This is currently blocking the 0.13.1 release.
{code}
mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
mahout-hdfs-0.13.1-SNAPSHOT.jar
mahout-math-0.13.1-SNAPSHOT.jar
mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
mahout-mr-0.13.1-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
mahout-spark_2.11-0.13.1-SNAPSHOT.jar
{code}

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-23 21:47:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061539#comment-16061539 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123573034

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

this _should_ be ok, i'm not sure if we have a need for a default `Context` here, but we may want to accept a `Context` in place here, Which, It seems has been added below at line 56 - I'm not sure what this has replaced thogh.(line 56). I'll dig into it later.. From what you said earlier this doesn't seem to be API breaking.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-23 21:48:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061541#comment-16061541 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123850836

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

getting: ```*** RUN ABORTED *** java.lang.NoSuchMethodError: scala.runtime.IntRef.create(I)Lscala/runtime/IntRef; at org.apache.mahout.viennacl.opencl.package$.repackCSR(package.scala:227) at org.apache.mahout.viennacl.opencl.package$.toVclCmpMatrixAlt(package.scala:120) at org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$gpuRWCW(GPUMMul.scala:161) at org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$jvmRWRW(GPUMMul.scala:208) at org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78) at org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78) at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:127) at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:33) at org.apache.mahout.math.scalabindings.RLikeMatrixOps.$percent$times$percent(RLikeMatrixOps.scala:37) at org.apache.mahout.opencl.viennacl.ViennaCLSuiteVCL$$anonfun$2.apply$mcV$sp(ViennaCLSuiteVCL.scala:92)```

when running `mvn test` in the viennacl package.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-23 22:45:01 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061605#comment-16061605 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123857432

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

hmm. when running `mvn test` on a scala 2.11.2 build it seems to bee looking for ViennCL built for 2.10: `mahout-native-viennacl_2.10 `
```
[INFO] Copying 3 resources
[INFO]
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile) @ mahout-native-viennacl_2.10 ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ mahout-native-viennacl_2.10 ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ mahout-native-viennacl_2.10 ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- scalatest-maven-plugin:1.0:test (test) @ mahout-native-viennacl_2.10 ---
```
Maybe the scalatest plugin in scala version is hardcoded in a pom somewere?.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-23 23:54:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061655#comment-16061655 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123863312

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo I have no problems building this for scala-2.11, with E.g.: `mvn clean install -Dscala.version=2.11.2 -Dscala.compat.version=2.11 -Pviennacl -Phadoop2 -DskipTests`` *note* the scala version is @ 2.11 which I think wee may need to make our cap due to the Breeze vector cap @scala 2.11.2 :
```
[WARNING] org.scalanlp:breeze_2.11:0.11.2 requires scala version: 2.11.4
```
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Mahout Build Tools ................................. SUCCESS [ 3.189 s]
[INFO] Apache Mahout ...................................... SUCCESS [ 0.080 s]
[INFO] Mahout Math ........................................ SUCCESS [ 13.226 s]
[INFO] Mahout HDFS ........................................ SUCCESS [ 3.310 s]
[INFO] Mahout Map-Reduce .................................. SUCCESS [ 21.442 s]
[INFO] Mahout Integration ................................. SUCCESS [ 6.183 s]
[INFO] Mahout Examples .................................... SUCCESS [ 21.106 s]
[INFO] Mahout Math Scala bindings ......................... SUCCESS [ 54.202 s]
[INFO] Mahout Spark bindings .............................. SUCCESS [ 51.939 s]
[INFO] Mahout Native VienniaCL OpenCL Bindings ............ SUCCESS [ 48.965 s]
[INFO] Mahout Native VienniaCL OpenMP Bindings ............ SUCCESS [ 25.782 s]
[INFO] Mahout Release Package ............................. SUCCESS [ 2.567 s]
[INFO] Mahout H2O backend ................................. SUCCESS [ 22.381 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:34 min
[INFO] Finished at: 2017-06-23T16:39:21-07:00
[INFO] Final Memory: 132M/1124M
[INFO] -----------------------------------
```

tests are failing for me though in `viennacl`. I'll to dig deeper.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 01:10:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061714#comment-16061714 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123866703

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

@andrewpalumbo thanks for the review

If you look at line 49 and 56 below- this is what replaces. Line 49 lets you call the constructor with out a default context (same as what happened here) line 56 lets you explicitly pass a context.

Re: Scala 2.11.2, I made a comment on MAHOUT-1975. We probably need to figure out where the dependency comes from and try to work around it.

Will also dig in on my end- viennacl always fails for me bc I don't have strong enough GPUs- but results should be same for ViennaCL-OMP.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 01:35:02 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061723#comment-16061723 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123867359

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

@andrewpalumbo can you try

`mvn test -Dscala.version=2.11.8 -Dscala.compat.version=2.11`

The reason I believe this works is-
```
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.compat.version}</artifactId>
</dependency>
```
where scala-compat-version is by default 2.10. So when you `mvn test` you are doing so with scala-test_2.10, and that's where its losing its mind.

(Also explains why these were passing in Travis)

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 20:45:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062121#comment-16062121 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885153

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

rebuilding abd testing now with the correct scala flags.. noticed this in spark/dependency-reduced-pom.xmlpom.xml: [INFO] Reading assembly descriptor: src/main/assembly/dependency-reduced.xml

```
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'org.apache.mahout:mahout-native-viennacl_2.10'
o 'org.apache.mahout:mahout-native-viennacl-omp_2.10'

[INFO] Building jar: /home/andy/sandbox/mahout_cuda/spark/target/mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
```
*easyhack*: add
to `spark/dependency reduced.xml`:
```
'org.apache.mahout:mahout-native-viennacl_2.11'
'org.apache.mahout:mahout-native-viennacl-omp_2.11'
```
though that pom should honor the `{scala.compat.version}`

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 20:53:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062126#comment-16062126 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885270

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo:
```
$MAHOUT_HOME/viennacl$ mvn test -Dscala.version=2.11.2 -Dscala.compat.version=2.11 -Pviennacl
```
(I'd tried built with 2.11.2)
tests pass:
```
All tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-06-24T13:49:59-07:00
[INFO] Final Memory: 20M/296M
[INFO] ------------------------------------------------------------------------
```
Sweet- I'd like to try this in Pseudo cluster mode as well, this afternoon.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 20:55:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062128#comment-16062128 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885295

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

If you'd like to merge this first i'd be +1 on that. Then testing on pseudo cluster could be a separate issue. The `spark/dependency reduced.xml` needs to be updated.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-24 22:47:02 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062164#comment-16062164 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123887027

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo lgtm - ship it! we swill still need to do some testing against other spark versions though. As well, there are some other issues that I've noticed, but can be addressed in other PRs on top of this anyways, eg. #327.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-25 13:05:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062320#comment-16062320 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123898430

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

fwiw- travis now runs all unit tests in pseudocluster. just fyi- of spark 1.6, 2.0, 2.1

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-25 17:54:01 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062390#comment-16062390 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123904856

--- Diff: viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
@Name(Array("viennacl::matrix<double,viennacl::column_major>"))
final class DenseColumnMatrix(initDefault:Boolean = true) extends MatrixBase {

- def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+ def this(nrow: Int, ncol: Int) {
+ this(false)
+ allocate(nrow, ncol, new Context())
+ }
+
+ def this(nrow: Int, ncol: Int, ctx: Context) {
this(false)
allocate(nrow, ncol, ctx)
}

- def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new Context(Context.MAIN_MEMORY)) {
--- End diff --

+1 - I'd forgotten that last night.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ASF GitHub Bot (JIRA)

2017-06-26 21:41:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063841#comment-16063841 ]

ASF GitHub Bot commented on MAHOUT-1988:
----------------------------------------

Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/326

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Trevor Grant (JIRA)

2017-06-26 21:44:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Grant resolved MAHOUT-1988.
----------------------------------
Resolution: Fixed

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Hudson (JIRA)

2017-06-26 22:13:00 UTC

Permalink

[ https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063886#comment-16063886 ]

Hudson commented on MAHOUT-1988:
--------------------------------

SUCCESS: Integrated in Jenkins build Mahout-Quality #3492 (See [https://builds.apache.org/job/Mahout-Quality/3492/])
MAHOUT-1988 Make Native Solvers Scala 2.11 Complient closes (rawkintrevo: rev c17bee3c2705495b638d81ae2ad374bf7494c3f3)
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseRowMatrix.scala
* (edit) viennacl-omp/src/main/scala/org/apache/mahout/viennacl/openmp/javacpp/DenseRowMatrix.scala
* (edit) .travis.yml
* (edit) viennacl-omp/src/main/scala/org/apache/mahout/viennacl/openmp/javacpp/DenseColumnMatrix.scala
* (edit) viennacl-omp/src/main/scala/org/apache/mahout/viennacl/openmp/javacpp/CompressedMatrix.scala
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/VCLVector.scala
* (edit) viennacl-omp/src/main/scala/org/apache/mahout/viennacl/openmp/javacpp/VCLVector.scala
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/CompressedMatrix.scala
* (edit) viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala